Re: Tighten asserts on ParallelWorkerNumber a little bit - Mailing list pgsql-hackers

On 3/13/26 11:53, Bertrand Drouvot wrote:
> ...
>
>> So AFAICS the assert(s) should be
>>
>>   Assert(ParallelWorkerNumber < node->shared_info->num_workers);
> 
> I think that you're right. It looks like the first one has been introduced
> by bf11e7ee2e3 and then the others are probably copy/paste.
> 
>> I don't think we had issues with this not catching a bug. But it may be
>> a bit misleading, so worth fixing and (probably) backpatching.
> 
> I do agree.
> 
> With that patch applied, the remaining one:
> 
> $ git grep "<=.*num_workers"
> src/backend/executor/nodeGatherMerge.c: Assert(nreaders <= castNode(GatherMerge, gm_state->ps.plan)->num_workers);
> 
> does not need to be fixed, so I think that your patch does not miss any and
> LGTM.
> 

Thanks. Pushed and backpatched.

-- 
Tomas Vondra