Re: Fix a typo in pg_rotate_logfile - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Fix a typo in pg_rotate_logfile
Date
Msg-id 772E8FE1-B1F7-4472-A132-06498B9D6907@yesql.se
Whole thread Raw
In response to Fix a typo in pg_rotate_logfile  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Fix a typo in pg_rotate_logfile
List pgsql-hackers
> On 12 Feb 2024, at 21:32, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:

> I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c
> - the hint message wrongly mentions that pg_logfile_rotate is part of
> the core; which is actually not. pg_logfile_rotate is an adminpack's
> 1.0 SQL function dropped in 2.0. The core defines pg_rotate_logfile
> SQL function instead, so use that. Here's a patch to fix the typo.

Nice catch!  This needs to be backpatched all the way down to 12 as that
function wen't away a long time ago (it was marked as deprecated all the way
back in 9.1).

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Popcount optimization using AVX512
Next
From: Bharath Rupireddy
Date:
Subject: Add test module for verifying backtrace functionality