Andrew Martin wrote:
>
> Just run the regression tests on 6.1 and as I suspected the array bug
> is still there. The regression test passes because the expected output
> has been fixed to the *wrong* output.
>
> As I have said before, I don't use arrays, so this doesn't affect me,
> but it is very bad practice that this should be released with the
> regression tests claiming that arrays work when they don't.
from the regression test README:
The interpretation of array specifiers (the curly braces around atomic
values) appears to have changed sometime after the original regression
tests were generated. The current ./expected/*.out files reflect this
new interpretation, which may not be correct!
It seems to me to be *pointless* to carry forward long-term behavior as
a failure for regression testing when the regression testing really is
designed to ensure that behavior is consistant and that a new
installation is functioning "properly", which means that it behaves as
well as a reference installation behaves. Don't know who uses arrays,
but it apparently isn't anyone who cares enough to try fixing the
problem.
(OK, I feel better now :)
Do you actually understand how the array output is supposed to look?
Since no versions of the code do it "correctly", I've been confused as
to what the array rules really are. Is the stuff munged internally, or
only for output?? Wouldn't mind working on it but need to understand the
correct behavior first...
- Tom
> > Please make sure that this is in the TODO list and for the next release
> it really should be fixed or array functionality disabled.
>
> The current (wrong) expected output is:
>
> QUERY: SELECT * FROM arrtest;
> a |b |c |d |e
> -----------+---------------+-------------+-----------------+-------------
> {1,2,3,4,5}|{{{0,0},{1,2}}}|{} |{} |
> {11,12,23} |{{3,4},{4,5}} |{"foobar"} |{{"elt1","elt2"}}|{"3.4","6.7"}
> {} |{3,4} |{"foo","bar"}|{"bar","foo"} |
>
> The correct output is:
>
> QUERY: SELECT * FROM arrtest;
> a b c d e
> ------------ ---------------------- -------------- ------------------ --------------
> {1,2,3,4,5} {{{0,0}},{{1,2}}} {} {}
> {11,12,23} {{{3},{4}},{{4},{5}}} {"foobar"} {{"elt1","elt2"}} {"3.4","6.7"}
> {} {{{3,4},{0,0}}} {"foo","bar"} {{"bar"},{"foo"}}
>
> The problem comes in columns b and d which are 3D and 2D arrays.
> The wrong output is munging the dimensionality of these arrays.
------------------------------
