Re: timestamp_in DirectFunctionCall - Mailing list pgsql-hackers

From Tom Lane
Subject Re: timestamp_in DirectFunctionCall
Date
Msg-id 7652.1285961108@sss.pgh.pa.us
Whole thread Raw
In response to timestamp_in DirectFunctionCall  (Marios Vodas <mvodas@gmail.com>)
List pgsql-hackers
Marios Vodas <mvodas@gmail.com> writes:
> This is how timestamp_in starts, *#ifdef NOT_USED* is a litle bit confusing.
> Datum timestamp_in(PG_FUNCTION_ARGS)
> {
>     char       *str = PG_GETARG_CSTRING(0);

> #ifdef NOT_USED
>     Oid            typelem = PG_GETARG_OID(1);
> #endif
>     int32        typmod = PG_GETARG_INT32(2);

The ifdef is just to document that timestamp_in is ignoring an input
function's standard second argument.

Personally I'd pass -1 for the third argument rather than hard-wiring
a specific value.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: wip: functions median and percentile
Next
From: Robert Haas
Date:
Subject: Re: patch: tsearch - some memory diet