Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet
Date
Msg-id 7635.1464712481@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, May 26, 2016 at 3:28 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> 99% of the time, you'd be right.  But this is an unusual case, for the
>> reasons I mentioned before.

> I tend to agree with Nikolay.  I can't see much upside in making this
> change.  At best, nothing will break.  At worst, something will break.
> But how do we actually come out ahead?

We come out ahead by not having to make the documentation more confusing.

Basically, we have the opportunity to fix an ancient mistake here at
very low cost.  I do not think that doubling down on the mistake is
a better answer.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet
Next
From: Peter Eisentraut
Date:
Subject: Re: parallel.c is not marked as test covered