Fix PSQL Console plugin for OS X - Mailing list pgadmin-hackers

From Nicola Vitacolonna
Subject Fix PSQL Console plugin for OS X
Date
Msg-id 75CDF5B1-6EC5-4553-B8DF-7A28D00FA9C8@gmail.com
Whole thread Raw
Responses Re: Fix PSQL Console plugin for OS X
List pgadmin-hackers
The PSQL Console command has been broken for a long time on OS X. Could you please fix it?

This is how the command should look like:

Command=/usr/bin/osascript -e 'ignoring application responses' -e 'tell application "Terminal"' -e 'activate' -e 'do
script""' -e 'do script "\'$$PGBINDIR/psql\' --host \'$$HOSTNAME\' --port $$PORT --username \'$$USERNAME\'
\'$$DATABASE\'&& exit || sleep 5 && exit" in window 1' -e 'end tell' -e 'end ignoring' 

For humans:

ignoring application responses
    tell application "Terminal"
        do script "" -- open a new Terminal window
        do script "$$PGBINDIR/psql --host '$$HOSTNAME' --port $$PORT --username '$$USERNAME' '$$DATABASE' && exit ||
sleep5 && exit" in window 1 
        activate
    end tell
end ignoring

The changes are as follows:

1) add `do script “”` to open a new Terminal window. This is necessary because in the current window there may be a
runningprocess. 
2) Remove `with command` (not wrong, but redundant).
3) Add `in window 1`. This is essential, otherwise the command fails.
4) Move `activate` at the end. This change is not strictly necessary, it is just a matter personal preference.

Thanks,
Nicola

PS: Is there a way to contribute to the code directly (à la Github)?


Attachment

pgadmin-hackers by date:

Previous
From: Thom Brown
Date:
Subject: Speed up node animation in pgAdmin4
Next
From: Surinder Kumar
Date:
Subject: Re: [PATCH] Enhancement in sql-field control [pgAdmin4]