Re: Postmaster crashes on SIGHUP when oauth_validator_libraries holds only whitespace - Mailing list pgsql-bugs

-    if (oauth_validator_libraries_string[0] == '\0')
-    {
-        ereport(elevel,
-                errcode(ERRCODE_CONFIG_FILE_ERROR),
-                errmsg("parameter \"%s\" must be set for authentication method \"%s\"",
-                       "oauth_validator_libraries", "oauth"),
-                errcontext("line %d of configuration file \"%s\"",
-                           line_num, file_name));
-        *err_msg = psprintf("parameter \"%s\" must be set for authentication method \"%s\"",
-                            "oauth_validator_libraries", "oauth");
-        return false;
-    }
-
     /* SplitDirectoriesString needs a modifiable copy */
     rawstring = pstrdup(oauth_validator_libraries_string);

pstrdup calls strlen which segfault on NULL.  oauth_validator_libraries_string
has a default value of "" so it cannot be set to NULL by user action, but the
global variable backing the GUC is initialized as NULL so I wonder if it's
worth adding defensive programming like the below, or perhaps an Assert?

        /* SplitDirectoriesString needs a modifiable copy */
-       rawstring = pstrdup(oauth_validator_libraries_string);
+       rawstring = pstrdup(oauth_validator_libraries_string ?
+                                               oauth_validator_libraries_string : "");

--
Daniel Gustafsson