Re: XX000: tuple concurrently deleted during DROP STATISTICS - Mailing list pgsql-hackers

From Tom Lane
Subject Re: XX000: tuple concurrently deleted during DROP STATISTICS
Date
Msg-id 751183.1699473494@sss.pgh.pa.us
Whole thread Raw
In response to Re: XX000: tuple concurrently deleted during DROP STATISTICS  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: XX000: tuple concurrently deleted during DROP STATISTICS
List pgsql-hackers
Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> On 11/8/23 16:52, Tom Lane wrote:
>> Shouldn't DROP STATISTICS be taking a lock on the associated table
>> that is strong enough to lock out ANALYZE?

> Yes, I think that's the correct thing to do. I recall having a
> discussion about this with someone while working on the patch, leading
> to the current code. But I haven't managed to find that particular bit
> in the archives :-(
> Anyway, the attached patch should fix this by getting the lock, I think.

This looks generally correct, but surely we don't need it to be as
strong as AccessExclusiveLock?  There seems no reason to conflict with
ordinary readers/writers of the table.

ANALYZE takes ShareUpdateExclusiveLock, and offhand I think this
command should do the same.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: XID-wraparound hazards in LISTEN/NOTIFY
Next
From: Tom Lane
Date:
Subject: Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)