On 11/15/2017 04:30 PM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 11/15/2017 02:17 PM, Andrew Dunstan wrote:
>>> Yeah, that was my first instinct. But then how do the test_rls_hooks
>>> tests succeed? They too have a shared_preload_library.
>> Aha, it does
>> LOAD 'test_rls_hooks';
>> at the start of its script. Of course we can't do that here.
>> Not sure what the best way to resolve this is. For now I'm inclined just
>> to override the installcheck target in the module's makefile and disable
>> it in vcregress.pl.
> Yeah.
>
>> Maybe we need to shift from installcheck to check mode for these
>> modules. That would involve a buildfarm script change.
> Seems like expending an awful lot of cycles in support of a rather trivial
> feature.
Possibly. At any rate I'm not going to do it immediately.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
