Re: [PATCH] log_statement docs - Mailing list pgsql-docs

From Tom Lane
Subject Re: [PATCH] log_statement docs
Date
Msg-id 7494.1267124877@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] log_statement docs  (Bruce Momjian <bruce@momjian.us>)
Responses Re: [PATCH] log_statement docs  (Bruce Momjian <bruce@momjian.us>)
List pgsql-docs
Bruce Momjian <bruce@momjian.us> writes:
> gabrielle wrote:
>> On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Shouldn't it just say "all means all", if we think that needs to be
>>> explained?
>>
>> I think it should say something about the "all" option.  I read &
>> re-read that section trying to figure out what the difference between
>> "mod" and "all" was, and finally asked on the irc channel.  As it
>> stands, it essentially says "there are three options to this command,
>> but we're only going to tell you about two of them." :)

> Well, if you take a look at utility.c:GetCommandLogLevel() you will see
> that ALL includes a lot more commands than just SELECT.

Yeah.  My objection was not to documenting ALL, it was to documenting it
with exactly that sentence, which seems both needlessly complicated and
subject to errors of omission.

            regards, tom lane

pgsql-docs by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCH] log_statement docs
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCH] log_statement docs