Re: make -C libpq check fails obscurely if tap tests are disabled - Mailing list pgsql-hackers

From Tom Lane
Subject Re: make -C libpq check fails obscurely if tap tests are disabled
Date
Msg-id 748838.1658522443@sss.pgh.pa.us
Whole thread Raw
In response to Re: make -C libpq check fails obscurely if tap tests are disabled  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: make -C libpq check fails obscurely if tap tests are disabled
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2022-Jul-22, Alvaro Herrera wrote:
>> It's not very common -- we do have some target-specific variable
>> assignments, but none of them use 'export'.  I saw somewhere that this
>> works from Make 3.77 onwards, and we require 3.80, so it should be okay.
>> The buildfarm will tell us ...

> Hm, so prairiedog didn't like this:
> According to 32568.1536241083@sss.pgh.pa.us, prairiedog is on Make 3.80.

Yeah, it is.  I looked at the gmake manual on that machine, and its
description of "export" seems about the same as what I see in a
modern version.  So it should work ... but we've found bugs in 3.80
before.

Let me poke at it and see if there's a variant that works.
The wording of the message suggests that maybe breaking it into
two separate rules would help.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: predefined role(s) for VACUUM and ANALYZE
Next
From: Robert Haas
Date:
Subject: Re: let's disallow ALTER ROLE bootstrap_superuser NOSUPERUSER