Re: Add missing period to DETAIL messages - Mailing list pgsql-hackers

From Chao Li
Subject Re: Add missing period to DETAIL messages
Date
Msg-id 74359511-9F84-481E-B133-D2F68775D1CE@gmail.com
Whole thread Raw
In response to Add missing period to DETAIL messages  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Add missing period to DETAIL messages
List pgsql-hackers

> On Apr 9, 2026, at 12:27, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi,
>
> According to the error message style guide [1] "Detail and hint
> messages: Use complete sentences, and end each with a period."
>
> I found some DETAIL messages not following that period rule.
>
> PSA a patch that fixes the missing period. In passing, I also fixed
> some capitalization.
>
> ======
> [1] https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-STYLE-GUIDE-GRAMMAR-PUNCTUATION
>
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
> <v1-0001-Add-missing-period-to-DETAIL-messages.patch>


```
-                     errdetail("password must be at least \"passwordcheck.min_password_length\" (%d) bytes long",
+                     errdetail("password must be at least \"passwordcheck.min_password_length\" (%d) bytes long.”,
```

First “p” should be capital.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Dapeng Wang
Date:
Subject: Re: create table like including storage parameter
Next
From: Nazir Bilal Yavuz
Date:
Subject: Re: Upload only the failed tests logs to the Postgres CI (Cirrus CI)