Request a Demo
Home   >   mailing lists

Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments - Mailing list pgsql-hackers

From Chao Li
Subject Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Date
Msg-id 7415F7DF-FA45-49E1-AC70-04868714DC8A@gmail.com
Whole thread Raw
In response to Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 

> On Oct 28, 2025, at 07:35, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Mon, Oct 27, 2025 at 09:55:38AM -0500, Nathan Bossart wrote:
>> /*
>>  * DISABLE_LEADER_PARTICIPATION disables the leader's participation in
>>  * parallel index builds.  This may be useful as a debugging aid.
>> -#undef DISABLE_LEADER_PARTICIPATION
>> + *#undef DISABLE_LEADER_PARTICIPATION
>>  */
>> 
>> IMHO we should either remove this line or move it out of the comment.
>> AFAICT we ordinarily don't #undef debugging stuff like this, presumably so
>> you can change it with compile flags.
> 
> I would put this one on a separate line, outside the comment.  It's
> minor, still we use this style in pg_config_manual.h.  See around
> REALLOCATE_BITMAPSETS.
> --
> Michael

+1

--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: display hot standby state in psql prompt
Next
From: "iosif"
Date:
Subject: when called from extract_restriction_or_clauses(), the 4th check in join_clause_is_movable_to() is unnecessary