Re: Switch opclass option functions to be STRICT (currently non-STRICT) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Switch opclass option functions to be STRICT (currently non-STRICT)
Date
Msg-id 740873.1786973581@sss.pgh.pa.us
Whole thread
Responses Re: Row pattern recognition
Re: Switch opclass option functions to be STRICT (currently non-STRICT)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> However, if one looks at the internals of any of these functions, it
> is easy to note that they are not able to handle NULL inputs at all,
> leading to a crash (aka 8f7e35b08ad5).  It looks like a mistake to me
> to declare them as not STRICT, while their internals are written to
> not be able to handle NULL.

Probably a mistake, but it's of no consequence.  These all take
type internal so they can't be called from SQL; if they could be,
the hazards from passing a not-NULL pointer would be far worse
than what happens with a NULL.  I can't get excited about doing
work to change it.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jehan-Guillaume de Rorthais
Date:
Subject: Re: Possible Visibility Map corruption in supported branches?
Next
From: Bertrand Drouvot
Date:
Subject: Re: basebackup: do not verify checksums on pages written before enabling checksums