Re: [HACKERS] Function structure in formatting.c - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] Function structure in formatting.c
Date
Msg-id 7344.1206219729@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Function structure in formatting.c  ("Brendan Jurd" <direvus@gmail.com>)
Responses Re: [HACKERS] Function structure in formatting.c  ("Brendan Jurd" <direvus@gmail.com>)
List pgsql-patches
"Brendan Jurd" <direvus@gmail.com> writes:
> I noticed an editing error in the patch I originally submitted; it
> defined the same debugging macro twice.
> I've attached a fresh copy of the patch against the current HEAD with
> the fix included.

Working through this patch now.  I found one thing that seems to be
a mistake (probably an overenthusiastic search&replace): the patch
changes
-    {"iy", 2, dch_date, DCH_IY, TRUE},
to
+    {"iyear", 2, DCH_IY, TRUE},

The removal of dch_date is intended, but surely the keyword should
still be "iy".  I'm proceeding on that assumption, but if this change
was actually intended, please explain.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Luke Lonergan"
Date:
Subject: Re: Auto Partitioning Patch - WIP version 1
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Function structure in formatting.c