Re: Simplify passing of configure arguments to pg_config - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Simplify passing of configure arguments to pg_config
Date
Msg-id 7321.1575349428@sss.pgh.pa.us
Whole thread Raw
In response to Simplify passing of configure arguments to pg_config  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Simplify passing of configure arguments to pg_config  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> Currently, configure puts the configure args into the makefiles and
> then have the makefiles pass them to the build of pg_config.  That looks 
> like an unnecessary redirection, and indeed that method was
> put in place when pg_config was a shell script.  We can simplify that
> by having configure put the value into pg_config.h directly.  This
> also makes the standard build system match how the MSVC build system
> already does it.

I dunno, is this really an improvement?  It makes the handling of
VAL_CONFIGURE different from every other one of the values passed
into pg_config, and I don't see any countervailing addition of
some other regularity.  I'm also a bit suspicious of the ad-hoc
escaping step ...

            regards, tom lane



pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Bogus EXPLAIN results with column aliases for mismatched partitions
Next
From: Amit Khandekar
Date:
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files