Re: pgindent versus struct members and typedefs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent versus struct members and typedefs
Date
Msg-id 729177.1778039019@sss.pgh.pa.us
Whole thread
In response to Re: pgindent versus struct members and typedefs  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Nathan Bossart <nathandbossart@gmail.com> writes:
> For fun, I spent some time with an AI tool to develop the attached fix for
> this problem.  The explanation seems reasonable to me, although I am by no
> means a pgindent expert.  When I looked at this in December, I did find
> this similar commit from upstream [0], but I failed to make the connection
> with last_u_d.  0002 is the result of a pgindent run after applying 0001.
> You'll notice that it fixes the exact set of cases I found with grep
> upthread.

Those changes are clearly improvements.  I'm too tired to investigate
right now, but I wonder if we should adopt the upstream fix you
mention?  (Or more generally, other changes they made since we forked?)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alex Guo
Date:
Subject: Re: Fix DROP PROPERTY GRAPH "unsupported object class" error
Next
From: shveta malik
Date:
Subject: Re: Parallel Apply