Re: tuplesort_gettuple_common() and *should_free argument - Mailing list pgsql-hackers

From Tom Lane
Subject Re: tuplesort_gettuple_common() and *should_free argument
Date
Msg-id 7289.1481230925@sss.pgh.pa.us
Whole thread Raw
In response to Re: tuplesort_gettuple_common() and *should_free argument  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
Peter Geoghegan <pg@heroku.com> writes:
> On Wed, Dec 7, 2016 at 11:55 PM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> Should we be worried about breaking the API of tuplesort_get* functions?
>> They might be used by extensions. I think that's OK, but wanted to bring it
>> up. This would be only for master, of course, and any breakage would be
>> straightforward to fix.

> I don't think so. I'm not aware of any third party extensions that
> call tuplesort.c routines, despite having looked for them. I noticed
> that pg_repack doesn't. For any that do, they'll break in a
> predictable, obvious way.

Adding or subtracting function arguments is something we do all the time.
As long as it's not proposed for back-patch, I don't see a problem.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_dump vs. TRANSFORMs
Next
From: Petr Jelinek
Date:
Subject: Re: Logical Replication WIP