Re: Archive recovery crashes on win32 in HEAD - hot standby related? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Archive recovery crashes on win32 in HEAD - hot standby related?
Date
Msg-id 7286.1263658200@sss.pgh.pa.us
Whole thread Raw
In response to Re: Archive recovery crashes on win32 in HEAD - hot standby related?  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Sat, Jan 16, 2010 at 8:19 AM, Magnus Hagander <magnus@hagander.net> wrote:
>> Not knowing that code very well at this time, but is this perhaps a
>> structure not being properly initialized in EXEC_BACKEND case?

> It looks like KnownAssignedXidsHash is not initialized.  That's
> supposed to happen when CreateSharedProcArray calls
> KnownAssignedXidsInit, but that only happens for the first process to
> call that function... but without EXEC_BACKEND it'll just work anyway.

That code is completely broken as far as the division of labor between
"first" and not "first" is concerned ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Fix one more cast for _open_osfhandle().
Next
From: Simon Riggs
Date:
Subject: Re: Hot Standby and handling max_standby_delay