Re: [PATCH] Add size/acl information when listing databases - Mailing list pgsql-hackers

From Andrew Gilligan
Subject Re: [PATCH] Add size/acl information when listing databases
Date
Msg-id 7269E86B-552C-4E5F-B993-4CAAA7255644@tcpd.net
Whole thread Raw
In response to Re: [PATCH] Add size/acl information when listing databases  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Add size/acl information when listing databases  (Bruce Momjian <bruce@momjian.us>)
Re: [PATCH] Add size/acl information when listing databases  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 20 Jan 2008, at 04:34, Tom Lane wrote:
> Andrew Gilligan <andy@tcpd.net> writes:
>> Showing the size on \l+ probably makes more sense, but I imagine that
>> would require a very different approach due to the permissions
>> changes?
>
> I haven't experimented, but perhaps something along the lines of
>
>     case when has_database_privilege(current_user, db.oid, 'connect')
>     then pg_database_size...
>     else null
>     end
>
> would fix it.


Yep, that seems to do the trick.

I've attached an updated patch (based on 8.3RC2) that adds the ACL
information to \l and the size to \l+ if available.

Best regards,
-Andy




Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Add size/acl information when listing databases
Next
From: Teodor Sigaev
Date:
Subject: Re: message string fixes