Re: change default default_toast_compression to lz4? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: change default default_toast_compression to lz4?
Date
Msg-id 7267cdf8-f270-4cb1-9713-43c92cffe179@eisentraut.org
Whole thread Raw
In response to Re: change default default_toast_compression to lz4?  ("Euler Taveira" <euler@eulerto.com>)
Responses Re: change default default_toast_compression to lz4?
List pgsql-hackers
On 19.02.26 17:12, Euler Taveira wrote:
> On Thu, Dec 4, 2025, at 11:23 PM, Michael Paquier wrote:
>>
>> So this had better be adjusted in one go, in the shape of a tweak in
>> mingw_cross_warning_script with the addition of a --without-lz4, same
>> way as for ICU.
>>
> Done.
> 
>> Hmm.  It seems to me that we should just set not_found_dep if lz4
>> cannot be found, leaving meson_options.txt as it is currently, no?
>>
> Done.
> 
> Changes from last version:
> 
> - adjust CI
> - set not_found_dep instead of warning message
> - remove quotes from default_toast_compression value
> 
> It is aligned with ICU and readline behavior.

Your patch is adding documentation for the configure option 
--without-lz4, but you are leaving the documentation for --with-lz4 in 
place.  You should delete the latter.




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Cleaning up array_ref() and array_set()
Next
From: Peter Eisentraut
Date:
Subject: Re: change default default_toast_compression to lz4?