[HACKERS] What's with all the fflush(stderr) calls in pg_standby.c? - Mailing list pgsql-hackers

From Tom Lane
Subject [HACKERS] What's with all the fflush(stderr) calls in pg_standby.c?
Date
Msg-id 7232.1506268285@sss.pgh.pa.us
Whole thread Raw
Responses Re: [HACKERS] What's with all the fflush(stderr) calls in pg_standby.c?  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
This looks like cargo-cult programming to me.  stderr is almost
always line-buffered, making these fflush'es pointless.  If it's
not line-buffered, that's probably because it's going to a
noninteractive destination for which this wouldn't matter.
Moreover, none of our other programs do this.
        regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: [HACKERS] Built-in plugin for logical decoding output
Next
From: Pavel Stehule
Date:
Subject: [HACKERS] logical replication and statistics