Re: Tree-walker callbacks vs -Wdeprecated-non-prototype - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Tree-walker callbacks vs -Wdeprecated-non-prototype
Date
Msg-id 722832.1663690513@sss.pgh.pa.us
Whole thread Raw
In response to Re: Tree-walker callbacks vs -Wdeprecated-non-prototype  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Tree-walker callbacks vs -Wdeprecated-non-prototype
List pgsql-hackers
I wrote:
> (That verbiage is from the gcc manual; clang seems to act the same
> except that -Wcast-function-type is selected by -Wall, or perhaps is
> even on by default.)

Nah, scratch that: the reason -Wcast-function-type is on is that
we explicitly enable it, and have done so since de8feb1f3 (v14).
I did not happen to see this warning with gcc because the test runs
I made with this patch already had c35ba141d, whereas I did my
clang test on another machine that wasn't quite up to HEAD.
So we should have good warning coverage for bogus walker signatures
on both compilers.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [PATCH]Feature improvement for MERGE tab completion
Next
From: Alvaro Herrera
Date:
Subject: Re: A question about wording in messages