Re: Simplify formatting.c - Mailing list pgsql-patches

From Tom Lane
Subject Re: Simplify formatting.c
Date
Msg-id 7221.1211324977@sss.pgh.pa.us
Whole thread Raw
In response to Re: Simplify formatting.c  (Euler Taveira de Oliveira <euler@timbira.com>)
Responses Re: Simplify formatting.c
List pgsql-patches
Euler Taveira de Oliveira <euler@timbira.com> writes:
> Tom Lane wrote:
>> Also, it seems a bit inconsistent to be relying on
>> oracle_compat.c for upper/lower but not initcap.
>>
> I saw this inconsistence while I'm doing the patch. What about moving
> that upper/lower/initcap and wcs* code to another file. pg_locale.c?

That doesn't seem a particularly appropriate place for them.  pg_locale
is about dealing with the locale state, not about doing actual
operations based on the locale data.

I was just thinking of having oracle_compat expose an initcap routine.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Heikki Linnakangas"
Date:
Subject: Re: Map forks (WIP)
Next
From: Tom Lane
Date:
Subject: Re: Map forks (WIP)