Re: [HACKERS] Windows warnings from VS 2017 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Windows warnings from VS 2017
Date
Msg-id 7214.1506000631@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Windows warnings from VS 2017  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: [HACKERS] Windows warnings from VS 2017
Re: [HACKERS] Windows warnings from VS 2017
List pgsql-hackers
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> The speed of memset is hardly going to be the dominating factor in a
> 'CREATE DATABASE' command, so we could certainly afford to change to
> plain memset calls here.

Another thought is that it may be time for our decennial debate about
whether MemSet is worth the electrons it's printed on.  I continue to
think that any modern compiler+libc ought to do an equivalent or better
optimization given just a plain memset().  If that seems to be true
for recent MSVC, we could consider putting an #if into c.h to define
MemSet as just memset for MSVC.  Maybe later that could be extended
to other compilers.
        regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Re: proposal - psql: possibility to specify sort fordescribe commands, when size is printed
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] !USE_WIDE_UPPER_LOWER compile errors in v10+