Re: Not to to confusing - Mailing list pgsql-patches

"Greg Sabino Mullane" <greg@turnstep.com> writes:
>         else if (pg_strcasecmp(prev4_wd, "TABLE") == 0 &&
> !                        pg_strcasecmp(prev2_wd, "RENAME") == 0 &&
> !                                        pg_strcasecmp(prev_wd, "TO"))
>                 COMPLETE_WITH_CONST("TO");

In order to be somewhat consistent and not too confusing, could we
spell that as 'pg_strcasecmp(prev_wd, "TO") != 0' please?

(See previous rant about the undesirability of pretending that
integers are booleans...)

            regards, tom lane