Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. - Mailing list pgsql-hackers

Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Sep 05, 2018 at 11:39:50AM -0300, Alvaro Herrera wrote:
>> Should this be used in src/test/modules/{brin,test_commit_ts} also?

> Hmm, I have not thought those two ones.  commit_ts relies on REGRESS to
> be defined so as it does its cleanup.  brin is more interesting, it
> directly quotes that it needs to tweak its Makefile to do the cleanup,
> and it uses isolation tests.  Wouldn't it be more adapted to add a
> second extra switch for isolation tests similar to REGRESS?  We could
> call it ISOLATION, and it would list the set of isolation tests you
> could run from an extension.  That would be useful for a lot of folks.

> Thoughts?  It would be better to start a new thread rather than posting
> a new patch, but I'd rather take the temperature first.

Yeah, if we're going to introduce infrastructure for TAP tests, it'd
make sense to do so for isolation tests as well.

            regards, tom lane