Re: SR fails to send existing WAL file after off-line copy - Mailing list pgsql-hackers

From Tom Lane
Subject Re: SR fails to send existing WAL file after off-line copy
Date
Msg-id 7156.1288651650@sss.pgh.pa.us
Whole thread Raw
In response to Re: SR fails to send existing WAL file after off-line copy  (Greg Stark <gsstark@mit.edu>)
Responses Re: SR fails to send existing WAL file after off-line copy
List pgsql-hackers
Greg Stark <gsstark@mit.edu> writes:
> On Mon, Nov 1, 2010 at 12:37 AM, Heikki Linnakangas
> <heikki.linnakangas@enterprisedb.com> wrote:
>> Yes, indeed there is a corner-case bug when you try to stream the very first
>> WAL segment, with log==seg==0.

> This smells very much like
> http://article.gmane.org/gmane.comp.db.postgresql.devel.general/137052

> I wonder if there's some defensive programming way to avoid bugs of this sort.

It strikes me that it's not good if there isn't a recognizable "invalid"
value for WAL locations.  These bits of code show that there is reason
to have one.  Maybe we should teach initdb to start the WAL one segment
later, and then 0/0 *would* mean "invalid", and we could revert these
other hacks.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alex Hunsaker
Date:
Subject: Re: why does plperl cache functions using just a bool for is_trigger
Next
From: Tom Lane
Date:
Subject: Re: why does plperl cache functions using just a bool for is_trigger