Postgres Pro
Downloads
Home   >   mailing lists

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help
Date
Msg-id 70aea53e-8c02-46a0-a458-e86bd5ca188d@eisentraut.org
Whole thread Raw
In response to [patch] pg_basebackup: mention that spread checkpoints are the default in --help  (Michael Banck <mbanck@gmx.net>)
Responses Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help
List pgsql-hackers
Tree view 
On 19.10.23 11:39, Michael Banck wrote:
> Hi,
> 
> I believed that spread (not fast) checkpoints are the default in
> pg_basebackup, but noticed that --help does not specify which is which -
> contrary to the reference documentation.
> 
> So I propose the small attached patch to clarify that.

 >  printf(_("  -c, --checkpoint=fast|spread\n"
 >-          "                         set fast or spread 
checkpointing\n"));
 >+          "                         set fast or spread (default) 
checkpointing\n"));

Could we do like

   -c, --checkpoint=fast|spread
                          set fast or spread checkpointing
                          (default: spread)

This seems to be easier to read.

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: trying again to get incremental backup
Next
From: Nathan Bossart
Date:
Subject: Re: [dynahash] do not refill the hashkey after hash_search