Re: pgindent run coming - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent run coming
Date
Msg-id 7037.1244650704@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent run coming  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pgindent run coming  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> OK, I have found the cause of the script error, and it was my fault.  A
> month after we ran pgindent for 8.3 (December 2007), I received this
> issue from Tom:

> http://archives.postgresql.org/pgsql-hackers/2007-12/msg00800.php
>> Something I noticed the other day is that pgindent doesn't seem to treat
>> "struct foo" or "union foo" as a type name, which is pretty silly
>> because no context is needed at all to recognize that.

Ah.  So really the point here is that we want to specifically exclude
"struct stat" because there are too many places in our code where "stat"
is used as a regular identifier.  Are there any other special cases like
that?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Problem with listen_addresses = '*' on 8.4beta2 on AIX
Next
From: Tom Lane
Date:
Subject: Re: [BUGS] Cursor with hold emits the same row more than once across commits in 8.3.7