Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword - Mailing list pgsql-patches

From Tom Lane
Subject Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword
Date
Msg-id 7000.994625376@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword
List pgsql-patches
Peter Eisentraut <peter_e@gmx.net> writes:
> I never figured pg_hba.conf was complex.  It's one of the simplest
> configuration files I've seen.  What makes it look complex is that it
> begins with 700 lines explaining it, obscuring the actual content.

Now now, it's only ~ 200 lines of comments.  However...

Since pg_hba.conf is re-read on every connection, I've always thought
it was pretty bogus to bulk it up with that much internal documentation.
I've not tried to measure how much time it takes the postmaster to skip
over those 200 comment lines, but it can't be completely negligible.

I'd favor reducing the in-the-file docs to about one line saying "See
such-and-such-a-place in the documentation".  Or a README.  Or
something.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword
Next
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword