Re: small cleanup of ICU includes - Mailing list pgsql-hackers

From Andres Freund
Subject Re: small cleanup of ICU includes
Date
Msg-id 6inuxahcqdviyk5dssiicehg7akrdg5krwnxgrtthnyof4ujaz@uldw6cxp2c74
Whole thread Raw
In response to small cleanup of ICU includes  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: small cleanup of ICU includes
List pgsql-hackers
Hi,

On 2026-01-06 15:11:13 -0800, Jeff Davis wrote:
> Removes ICU includes from pg_locale.h, and instead include them in the
> few C files that need them.
> 
> There used to be more files that needed to use ICU functions, but after
> refactoring, there are only a few files that access ICU APIs directly.

Yay! I think this is a pretty significant improvement, removing the need for
the ugly C++ compat hackery we had introduced, as well as (imo) just being
cleaner.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: RFC: adding pytest as a supported test framework
Next
From: Peter Smith
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication