Re: WIP: new system catalog pg_wait_event - Mailing list pgsql-hackers

Hi,

On 8/19/23 12:00 PM, Michael Paquier wrote:
> On Sat, Aug 19, 2023 at 11:35:01AM +0200, Drouvot, Bertrand wrote:
>> Hi,
>>
>> On 8/18/23 12:31 PM, Michael Paquier wrote:
>> Thanks! Please find attached v9 fixing this typo.
> 
> I was looking at v8, and this looks pretty good to me. 

Great!

> I have
> spotted a few minor things.
> 
> +  proretset => 't', provolatile => 's', prorettype => 'record',
> This function should be volatile.  

Oh right, I copied/pasted this and should have paid more attention to
that part. Fixed in v10 attached.

> By the way, shouldn't the results of GetWaitEventExtensionNames() in
> the SQL function be freed?  I mean that:
>      for (int idx = 0; idx < nbextwaitevents; idx++)
>          pfree(waiteventnames[idx]);
>      pfree(waiteventnames);
> 

I don't think it's needed. The reason is that they are palloc in a
short-lived memory context while executing pg_get_wait_events().

> +   /* Handling extension custom wait events */
> Nit warning: s/Handling/Handle/, or "Handling of".

Thanks, fixed in v10.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com