Re: Enable -Wstrict-prototypes and -Wold-style-definition by default - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
Date
Msg-id 6edd397a-dd66-4f0d-ac58-4193fb1ea3dd@eisentraut.org
Whole thread Raw
In response to Re: Enable -Wstrict-prototypes and -Wold-style-definition by default  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
List pgsql-hackers
On 24.03.26 08:16, Bertrand Drouvot wrote:
> 0001:
> 
> +    '/external:anglebrackets',
> +    '/external:W0',
> 
> The doc [1], states:
> 
> "
> The /external compiler options are available starting in Visual Studio 2017 version 15.6.
> In versions of Visual Studio before Visual Studio 2019 version 16.10, the /external
> options require you also set the /experimental:external compiler option.
> "
> 
> We currently require MSVC 2019, but what if one is using a version < 16.10?

Per discussion in [0] we effectively require 16.11, so I think this 
should be ok.


[0]: 
https://www.postgresql.org/message-id/04ab76a3-186c-4a37-8076-e6882ebf9d43%40eisentraut.org



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Test timings are increasing too fast for cfbot
Next
From: Bharath Rupireddy
Date:
Subject: Re: Introduce XID age based replication slot invalidation