On 23.03.26 10:58, Jelte Fennema-Nio wrote:
> On Mon, 23 Mar 2026 at 10:27, Peter Eisentraut <peter@eisentraut.org> wrote:
>> I think we should commit the pg_list.h changes, since the C-style
>> compound literals are not a C++ feature at all, and so without this MSVC
>> would never get supported. (Or you couldn't use PostgreSQL lists, which
>> would be very limiting.)
>
> Sounds good to me.
This has been committed.
>> The other changes deal with designated initializers and flexible array
>> members. These are not a blocker, since extension authors could deal
>> with them themselves by adding appropriate compiler options or similar.
>
> I think we should add these flags to CXXFLAGS for MSVC by default,
> similar to how we add -std=gnu++11/-std=c++11 for other compilers. We
> can then document on the C++ extension docs page, that MSVC compilers
> require C++20 support.
Here is another tidied up patch set for this. I didn't go quite as far
as enabling C++20 by default in meson.build, this would just take more
time to work out and test all the different combinations, but I added
the flag to the Cirrus CI task, since there we know what compiler we have.
