Re: updates for handling optional argument in system functions - Mailing list pgsql-hackers

On 4/2/26 8:36 PM, Mark Wong wrote:
> I've attached v5, simply a needed rebase due to some other churn in
> pg_proc.dat.

Nice, I like the patch. The code changes looks good and I like the 
removal of these duplicate functions and use of default arguments. But I 
think the names of the arguments should be aligned with the names we 
have in the documentation. And that may mean that we should change the 
documentation.

For example:

= Code

pg_get_ruledef(rule, pretty)

= Docs

pg_get_ruledef(rule_oid, pretty_bool)

= Should docs maybe be updated to the following?

pg_get_ruledef(rule oid, pretty bool)

-- 
Andreas Karlsson
Percona