Re: [HACKERS] Duplicate assignment in Unicode/convutils.pm - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: [HACKERS] Duplicate assignment in Unicode/convutils.pm
Date
Msg-id 6db00b42-3c86-6352-212d-470d233889cf@iki.fi
Whole thread Raw
In response to [HACKERS] Duplicate assignment in Unicode/convutils.pm  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
On 04/07/2017 09:32 AM, Kyotaro HORIGUCHI wrote:
> Hi, I found that convutils.pl contains a harmless duplicate
> assignemnt.
>
>>     my $out = {f => $fname, l => $.,
>>                code => hex($1),
>>                ucs => hex($2),
>>                comment => $4,
>>                direction => BOTH,
>>                f => $fname,
>>                l => $.
>>             };
>
> Of course this is utterly harmless but wrong.
>
> The attached patch fixes this following other perl files around.
> No similar mistake is not found there.

Committed, thanks!

- Heikki




pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: [HACKERS] pg_basebackup: Allow use of arbitrary compression program
Next
From: Pavel Stehule
Date:
Subject: Re: [HACKERS] Undefined psql variables