On 8/18/24 20:09, Michael Paquier wrote:
> f68cd847fa40 but I've just lacked a combination of time and energy
> while the original commit was already enough.
>
> The code indentation was a bit incorrect, and I think that we should
> also have tests to stress that the insertion of the new stats is
> correct. I have fixed the indentation, added some tests and improved
> a couple of surrounding descriptions while on it.
Thank you for committing. I was thinking to add such test in next patch
set. I have a updated .vimrc to have correct indentation.
> I'm tempted to propose a separate improvement for the template of the
> fixed-numbered stats. We could do like pgstatfuncs.c where we use a
> macro to define the routines of the counters, and have one function
> for each counter incremented. That's a separate refactoring, so I'll
> propose that on a different thread.
I will take a look on this.
--
Kind Regards,
Yogesh Sharma
PostgreSQL, Linux, and Networking
Open Source Enthusiast and Advocate
PostgreSQL Contributors Team @ RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
