Re: Crash issue in PG18.5 regression - Mailing list pgsql-hackers

On Thu, 2026-08-13 at 22:17 -0700, Jeff Davis wrote:
> On Tue, 2026-08-11 at 14:31 -0400, Andres Freund wrote:
> > Hm. If I infer the pg_strlower() API correctly - it's utterly
> > underdocumented
>
> Agreed. Patch attached.
>
> > I'd also make i size_t, given that the input is size_t.  Perhaps
> > practically
> > no problem, but I see no reason to not use size_t here.
>
> Patch attached for that, too.
>
> I also attached patches to make all the functions work with
> collate_is_c, and fixed up the -1 API in 18.

Now with a C test module (made with AI assistance).

I plan to start committing these fairly soon. I'm not sure whether to
backport the C test module, but I included the patches to do so.

Regards,
    Jeff Davis