Re: [HACKERS] What does it mean by XLOG_BACKUP_RECORD? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] What does it mean by XLOG_BACKUP_RECORD?
Date
Msg-id 6b962e5a-2d54-01fb-85da-463fbbb3a374@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] What does it mean by XLOG_BACKUP_RECORD?  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [HACKERS] What does it mean by XLOG_BACKUP_RECORD?  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On 6/29/17 06:09, Masahiko Sawada wrote:
> Thanks, I agree to use XLOG_BACKUP_END instead.
> 
>> Worse, the current comment implies that
>> minRecoveryPoint is incorrectly set if it is true. Bleh.
> 
> Looking at the condition, we use minRecoveryPoint only when
> ControlFile->backupEndRequired is *false*. So I guess that it means
> that minRecoveryPoint is incorrectly set if
> ControlFile->backupEndReuired is true. Am I missing something?

I agree with you that the logic in the comment is correct.  I've
committed just the symbol change.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] parallel.c oblivion of worker-startup failures
Next
From: Vladimir Svedov
Date:
Subject: Re: proposal: alternative psql commands quit and exit