Re: split tablecmds.c - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: split tablecmds.c
Date
Msg-id 6a119f95-2309-464f-89d1-e17ff42a1a67@app.fastmail.com
Whole thread Raw
In response to Re: split tablecmds.c  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers
On Mon, Dec 1, 2025, at 3:18 PM, Álvaro Herrera wrote:
> My first thought would be to move code that deals with catalog changes
> to files in catalog/.  Also a couple of functions related to tablespaces
> could be perhaps be moved to commands/tablespace.c.
>

As Tom said partitioning has a big chunk of lines of code. I bet that's the
biggest portion. It seems a good candidate to be moved to a new file
(partitioning and inheritance). Besides your suggestion, I would add things
that set properties (RLS, reloptions, AM, replica identity, generated columns)
to another file (tableutils.c?).


--
Euler Taveira
EDB   https://www.enterprisedb.com/



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: split tablecmds.c
Next
From: Robert Haas
Date:
Subject: Re: Dynamic shared memory areas