Re: Remove obsolete pg_attrdef.adsrc column - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Remove obsolete pg_attrdef.adsrc column
Date
Msg-id 6E3F4F21-10C3-4914-829E-0A16B3C52CF3@yesql.se
Whole thread Raw
In response to Remove obsolete pg_attrdef.adsrc column  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Remove obsolete pg_attrdef.adsrc column  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
> On 23 Oct 2018, at 15:17, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>
> I propose the attached patch to remove the long-unused catalog column
> pg_attrdef.adsrc.

+1, I ran into a bug in an app as recently as today where adsrc was used
instead of pg_get_expr().

Patch looks good.  I probably would’ve opted for mentioning how to get a human
readable version on the page, along the lines of the attached version, but I
may be biased from having dealt with apps that need just that.

cheers ./daniel


Attachment

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: Postgres older version 8.3.7 on ubuntu 14
Next
From: David Fetter
Date:
Subject: Log timestamps at higher resolution