Re: Fix incorrect order of params in comment - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Fix incorrect order of params in comment
Date
Msg-id 6DDC4601-3117-4973-A426-ACA0D0F6DA16@yesql.se
Whole thread Raw
In response to Fix incorrect order of params in comment  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
> On 9 May 2025, at 23:50, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Fri, May 09, 2025 at 07:21:17PM +0200, Daniel Gustafsson wrote:
>> -=item $node->log_check($offset, $test_name, %parameters)
>> +=item $node->log_check($test_name, $offset, %parameters)
>> 
>> Check contents of server logs.
> 
> Right, good catch.  The internals of the routine use %params instead
> of %parameters, so perhaps this should be changed as well in the
> description?

Good point, not that documentation must match 1:1 but the other functions use
%params in their docs and matching that has value. Done.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Add an option to skip loading missing publication to avoid logical replication failure
Next
From: Andres Freund
Date:
Subject: Re: using index to speedup add not null constraints to a table