Re: [PATCHES] zic with msvc - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCHES] zic with msvc
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0FCAE@algol.sollentuna.se
Whole thread Raw
In response to Re: [PATCHES] zic with msvc  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> >>> + #ifdef WIN32
> >>> + #define _WIN32_WINNT 0x0400
> >>> + #endif
> >>
> >> Hmm ... in pg_ctl.c I see
> >>
> >> #define _WIN32_WINNT 0x0500
> >>
> >> Is there a reason for these to be different?  Are there
> other places
> >> that will need this (ie, maybe it should be in c.h instead?)
>
> > Not really. The default appears to be 0x0400 for MingW (or
> it wouldn't
> > have worked before), but 0x0350 or so for Visual C++.
> > If we define it to 0x0500 we pull in headers that will only work on
> > 2000 or newer.
>
> Hm.  Actually, if the rest of the backend compiles without
> this, then I guess the real question is what's zic.c doing
> that needs it?  pg_ctl.c has an excuse because it's doing
> weird MS-specific junk, but zic.c is supposed to be
> bog-standard portable code.  It really shouldn't have
> anything that's further out there than you could find in ten
> other places in the backend.

Only almost. There is a small function to emulate link(), which uses
CopyFileEx(). That's the one.

//Magnus

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: adminpack and pg_catalog
Next
From: "Dave Page"
Date:
Subject: Re: adminpack and pg_catalog