Re: [PATCHES] zic with msvc - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCHES] zic with msvc
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0FCA8@algol.sollentuna.se
Whole thread Raw
In response to Re: [PATCHES] zic with msvc  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCHES] zic with msvc  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> > + #ifdef WIN32
> > + #define _WIN32_WINNT 0x0400
> > + #endif
>
> Hmm ... in pg_ctl.c I see
>
> #define _WIN32_WINNT 0x0500
>
> Is there a reason for these to be different?  Are there other
> places that will need this (ie, maybe it should be in c.h instead?)

Not really. The default appears to be 0x0400 for MingW (or it wouldn't
have worked before), but 0x0350 or so for Visual C++.
If we define it to 0x0500 we pull in headers that will only work on 2000
or newer. But I don't really see that as a problem - I think we said
that we don't care about earlier ones anyway. in which case it's
definitly not a problem to stick it in c.h.

//Magnus

pgsql-hackers by date:

Previous
From: Theo Schlossnagle
Date:
Subject: Re: xlogdump fixups and WAL log question.
Next
From: Tom Lane
Date:
Subject: Re: [SPAM?] Re: Asynchronous I/O Support