Re: [PATCHES] Bad bug in fopen() wrapper code - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCHES] Bad bug in fopen() wrapper code
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0FC16@algol.sollentuna.se
Whole thread Raw
In response to Re: [PATCHES] Bad bug in fopen() wrapper code  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
> > > > I agree that this code is both wrong and unreadable
> (although in
> > > > practice the _setmode will probably never fail, which
> is why our
> > > > attention hasn't been drawn to it).  Is someone going
> to submit a
> > > > patch?  I'm hesitant to change the code myself since
> I'm not in a
> > > > position to test it.
> > >
> > > I can look at fixing that. Is it something we want to do
> for 8.2, or
> > > wait until 8.3? If there's a hidden bug, I guess 8.2?
> >
> > Magnus, is this the right fix?
>
> Claudio sent me some small updates to the patch;  updated
> version attached.

Tested, passes all regression tests on MingW.

//Magnus

pgsql-hackers by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: src/tools/msvc usage instructions
Next
From: Gregory Stark
Date:
Subject: Re: Another idea for dealing with cmin/cmax