Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCE92E764@algol.sollentuna.se
Whole thread Raw
Responses Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
List pgsql-hackers
> > Shall we add "volatile" quanlifier to at least pg_signal_queue?
>
> If that's changed by a separate thread, "volatile" seems essential.
> What about the mask variable?

Yes, that does seem right. Previously it would never be concurrently
modified, because it was always locked by the critical section, but now
we read it without locking, and we certainly don't want that optimized
away.

The mask is only ever written by the main thread, never by the signal
dispatching thread. So I think that one could do without.

//Magnus


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
Next
From: "Merlin Moncure"
Date:
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak