Re: remove partColsUpdated - Mailing list pgsql-hackers

From Chao Li
Subject Re: remove partColsUpdated
Date
Msg-id 6A9F3EEE-290C-4E51-8F41-12C302C6FB26@gmail.com
Whole thread Raw
In response to remove partColsUpdated  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: remove partColsUpdated
List pgsql-hackers
> On Oct 15, 2025, at 23:50, Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> This was first added in commit 2f17844 (v11), and AFAICT it was only used
> for a variable named update_tuple_routing_needed in ExecInitModifyTable(),
> which was removed by commit c5b7ba4 (v14).  Any objections to removing it
> now?
>
> --
> nathan
> <v1-0001-remove-partColsUpdated.patch>

Looks like this is only one assignment to it and nobody reads it. I don’t see a reason to retain it. Maybe back patch
through14? 

I tried to build, and “make check” with this patch, and everything looks good.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Instability of phycodorus in pg_upgrade tests with JIT
Next
From: Peter Smith
Date:
Subject: Should we say "wal_level = logical" instead of "wal_level >= logical"