> On Aug 11, 2026, at 16:32, Osama Abdul Qader <osamaabdulqader.cs@gmail.com> wrote:
>
> Hi Chao,
>
> Thanks for the feedback, That's make sense to me, I'll wait for Mr. Daniel's thought on whether the existing
010_client_untar.plcoverage is sufficient.
>
> Thanks,
> Osama Abdul Qader
>
> On Tue, Aug 11, 2026 at 1:28 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
>
> > On Aug 11, 2026, at 15:40, Osama Abdul Qader <osamaabdulqader.cs@gmail.com> wrote:
> >
> > Hi Chao,
> >
> > I noticed your commit f80cb3ae0737 ("Fix detection of truncated zstd-compressed backups"), which addresses the
truncatedZSTD backup issue I had reported.
> >
> > I added a regression test to src/bin/pg_verifybackup/t/008_untar.pl. The test creates a server-side ZSTD backup,
verifiesthe intact backup, truncates base.tar.zst by one byte, and then verifies that pg_verifybackup rejects the
truncatedbackup.
> >
> > The test passes with your fix:
> > make check -C src/bin/pg_verifybackup TESTS=t/008_untar
> >
> > Result: PASS.
> >
> > I noticed that your commit changes astreamer_zstd.c but does not add a regression test to 008_untar.pl. Would this
testbe useful to include with the fix?
> > Thanks,
> > Osama Abdul Qader
>
> Hi Osama,
>
> Thanks for your review and for adding the test. I think the test Daniel added to 010_client_untar.pl covers all three
astreamertypes.
>
> Your test covers server-side compression, but from the astreamer’s perspective, I don't think there is much
differencebetween client side and server side compression. Therefore, I am not sure that an additional server side test
isneeded. Let’s see what Daniel thinks.
>
> Best regards,
> --
> Chao Li (Evan)
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>
Hi, Osama,
FYI, when you want to attach a patch file, please include “nocfbot” in the file name. Otherwise, CommitFest will pick
upyour patch file and incorrectly ask for a rebase. See [1].
Resending v5 to recover the CF entry.
[1] https://wiki.postgresql.org/wiki/Cfbot#When_are_patches_tested?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
