On 2/18/26 11:11 PM, Zsolt Parragi wrote:
> See attached v2, which uses a meson-integrated version while only
> duplicating some of the code (and adding some python scripts).
Is the plan to use the Python scripts also in the Autotools build? E.g.
by calling them from the bash script?
> It uses static libraries, at first I tried to exclude it from the
> default build and add it as a test dependency, so it only gets built
> as part of `meson test` (but only once).
I feel this could add a substantial performance hit compared to the
shell script which uses -fsyntax-only, or am I wrong? Also -Wall seems
to be missing.
> * Meson before 1.7 ignores this and builds it anyway
Any idea why? Because this sounds like a potential showstopper since
Meson 1.7 is rather new.
> The header-guessing part is duplicated instead of using a common
> configuration file as that seemed smaller overall. The python code is
> a bit uglier because it uses chained ifs - I'm not sure what's the
> minimum python version the postgres builds officially requires? The
> current meson version depends only on 3.6, so I didn't want to use
> pattern matching.
It would be nice if the guessing was moved the config file too, or if
the shell script called out to the Python scripts. I am not a fan of
this duplication.
Another note: there is a mess where some scripts are now called
"headercheck" while others "headerscheck". We should pick one.
Andreas
